-
Notifications
You must be signed in to change notification settings - Fork 302
Added the 2 new options for endpoint type #7721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are introduced in Particular/ServicePulse#2580
servicepulse/usage.md
Outdated
@@ -89,6 +89,14 @@ An endpoint that is expected to no longer be used within the next 30 days. These | |||
|
|||
Not an NServiceBus endpoint. These are broker queues or other messaging infrastructure that should not be included in NServiceBus licensing calculations. | |||
|
|||
#### Gateway or Bridging Endpoint | |||
|
|||
This is an infrastructure endpoint used by the Particular Platform< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these <
be .
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that these have the same descriptions, will customers know which one to pick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on https://github.com/Particular/CustomerSuccess/issues/4834, which suggests to add a single entry.
Maybe that is the right way to go, thoughts @mikeminutillo ?
My concern is that "Infrastructure Endpoint" is too generic and users can confuse it with their own endpoints that deal with infrastructure.
That said, maybe we can be more explicit and name it "Particular Platform Endpoint"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind having them separate, but their descriptions should maybe provide more detail as to what fits in each category.
The Particular Platform Endpoints might explicitly mention Error, Audit, and Monitoring queues, as well as the ServiceControl instance input queues.
The Gateway or Bridging Endpoints might link off to the documentation for Gateway and Bridge (if links are possible)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I'll update these
@mikeminutillo I have updated this, please review again. |
These are introduced in Particular/ServicePulse#2580